feat(inkless): Add metrics for sealed partitions#534
Merged
Conversation
jeqo
reviewed
Mar 13, 2026
|
|
||
| private def reassigningPartitionsCount: Int = leaderPartitionsIterator.count(_.isReassigning) | ||
|
|
||
| private def sealedPartitionsCount: Int = onlinePartitionsIterator.count(_.isSealed) |
Contributor
There was a problem hiding this comment.
IIUC, this metric is only counting sealed leaders right? Should we use leaderPartitionsIterator instead`?
Contributor
Author
There was a problem hiding this comment.
Right, fixed it
19997dd to
def8c4a
Compare
jeqo
approved these changes
Mar 13, 2026
AnatolyPopov
pushed a commit
that referenced
this pull request
Mar 23, 2026
(cherry picked from commit 4777e9e)
jeqo
pushed a commit
that referenced
this pull request
Mar 23, 2026
jeqo
pushed a commit
that referenced
this pull request
Mar 23, 2026
(cherry picked from commit 4777e9e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.