feat(produce): optimize AppendCompleter to complete futures first#529
Merged
giuseppelillo merged 1 commit intomainfrom Mar 6, 2026
Merged
feat(produce): optimize AppendCompleter to complete futures first#529giuseppelillo merged 1 commit intomainfrom
giuseppelillo merged 1 commit intomainfrom
Conversation
Reorder AppendCompleter operations to minimize producer latency: 1. Build partition responses (fast, just object creation) 2. Complete futures IMMEDIATELY (critical path) 3. Populate batch coordinate cache (not on critical path) Previously, cache population happened before completing futures, meaning producers waited for cache operations that only benefit fetch operations. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces produce-path latency by reordering AppendCompleter.finishCommitSuccessfully() so that produce response futures are completed before non-critical cache population.
Changes:
- Reordered
finishCommitSuccessfully()to (1) build responses, (2) complete futures, then (3) populate the batch-coordinate cache. - Added a unit test asserting futures are completed before any
BatchCoordinateCache.put()calls.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| storage/inkless/src/main/java/io/aiven/inkless/produce/AppendCompleter.java | Reorders response completion ahead of cache writes to reduce producer latency. |
| storage/inkless/src/test/java/io/aiven/inkless/produce/AppendCompleterTest.java | Adds a test to enforce the future-completion-before-cache-write ordering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
giuseppelillo
approved these changes
Mar 6, 2026
jeqo
added a commit
that referenced
this pull request
Mar 23, 2026
…anch-consistency Replace keyword-based inkless commit detection (matching "inkless/diskless" in message) with --first-parent git log traversal. This only walks the main branch lineage, so upstream commits brought in via merge are naturally excluded. All remaining non-sync commits are inkless PRs regardless of their commit message wording. This fixes commits like "feat(produce): optimize AppendCompleter (#529)" being missed because they don't mention "inkless" or "diskless". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jeqo
added a commit
that referenced
this pull request
Mar 23, 2026
…anch-consistency Replace keyword-based inkless commit detection (matching "inkless/diskless" in message) with --first-parent git log traversal. This only walks the main branch lineage, so upstream commits brought in via merge are naturally excluded. All remaining commits with a PR number are inkless PRs regardless of their commit message wording. This fixes commits like "feat(produce): optimize AppendCompleter (#529)" being missed because they don't mention "inkless" or "diskless". Also fixes cherry-pick-to-release.sh to apply commits oldest-first instead of newest-first, ensuring dependencies are met. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jeqo
added a commit
that referenced
this pull request
Mar 23, 2026
…anch-consistency Replace keyword-based inkless commit detection (matching "inkless/diskless" in message) with --first-parent git log traversal. This only walks the main branch lineage, so upstream commits brought in via merge are naturally excluded. All remaining commits with a PR number are inkless PRs regardless of their commit message wording. This fixes commits like "feat(produce): optimize AppendCompleter (#529)" being missed because they don't mention "inkless" or "diskless". Also fixes cherry-pick-to-release.sh to apply commits oldest-first instead of newest-first, ensuring dependencies are met. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
AnatolyPopov
pushed a commit
that referenced
this pull request
Mar 23, 2026
Reorder AppendCompleter operations to minimize producer latency: 1. Build partition responses (fast, just object creation) 2. Complete futures IMMEDIATELY (critical path) 3. Populate batch coordinate cache (not on critical path) Previously, cache population happened before completing futures, meaning producers waited for cache operations that only benefit fetch operations. Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> (cherry picked from commit cff43f4)
jeqo
pushed a commit
that referenced
this pull request
Mar 23, 2026
Reorder AppendCompleter operations to minimize producer latency: 1. Build partition responses (fast, just object creation) 2. Complete futures IMMEDIATELY (critical path) 3. Populate batch coordinate cache (not on critical path) Previously, cache population happened before completing futures, meaning producers waited for cache operations that only benefit fetch operations. Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
jeqo
added a commit
that referenced
this pull request
Mar 24, 2026
…anch-consistency Replace keyword-based inkless commit detection (matching "inkless/diskless" in message) with --first-parent git log traversal. This only walks the main branch lineage, so upstream commits brought in via merge are naturally excluded. All remaining commits with a PR number are inkless PRs regardless of their commit message wording. This fixes commits like "feat(produce): optimize AppendCompleter (#529)" being missed because they don't mention "inkless" or "diskless". Also fixes cherry-pick-to-release.sh to apply commits oldest-first instead of newest-first, ensuring dependencies are met. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppendCompleter.finishCommitSuccessfully()to minimize producer latencyTest plan
futuresAreCompletedBeforeCachePopulation()test that verifies orderingAppendCompleterTesttests pass🤖 Generated with Claude Code