feat(inkless:config): disallow setting diskless.enable if diskless storage system is disabled#520
Merged
giuseppelillo merged 1 commit intomainfrom Mar 3, 2026
Conversation
…orage system is disabled
0d3c679 to
393767e
Compare
giuseppelillo
commented
Feb 27, 2026
Comment on lines
-526
to
-528
| // Only one between diskless.enable and remote.storage.enable can be set, no matter the value. | ||
| final boolean hasExplicitDiskless = isDisklessExplicitlySet || wasDisklessExplicitlySet; | ||
| final boolean hasExplicitRemoteStorage = isRemoteStorageExplicitlySet || wasRemoteStorageExplicitlySet; |
Contributor
Author
There was a problem hiding this comment.
Extracted to specific methods because validateDiskless was exceeding the limit on cyclomatic complexity.
jeqo
approved these changes
Mar 3, 2026
| Properties props, | ||
| Map<?, ?> configuredProps, | ||
| boolean isRemoteLogStorageSystemEnabled, | ||
| boolean isDisklessAllowFromClassicEnabled, |
Contributor
There was a problem hiding this comment.
nit: dead argument. Can be fixed in a follow-up.
giuseppelillo
added a commit
that referenced
this pull request
Mar 3, 2026
…orage system is disabled (#520)
giuseppelillo
added a commit
that referenced
this pull request
Mar 3, 2026
…orage system is disabled (#520)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.