Skip to content

Use slack blocks in slack handler#63

Merged
abahmed merged 7 commits intoabahmed:mainfrom
simonfrey:main
Feb 3, 2022
Merged

Use slack blocks in slack handler#63
abahmed merged 7 commits intoabahmed:mainfrom
simonfrey:main

Conversation

@simonfrey
Copy link
Copy Markdown
Collaborator

Changes proposed in this pull request:

  • Use slack blocks instead of attachments
  • Split up event's and logs's to ensure we can print all of them

@simonfrey simonfrey requested a review from abahmed as a code owner February 2, 2022 16:43
@simonfrey simonfrey removed the request for review from abahmed February 2, 2022 16:44
@simonfrey
Copy link
Copy Markdown
Collaborator Author

@abahmed Do you have any idea how I can rebase across forks? Actually only the commit 43cf445e955dc7660c9a119fbbf4baaef6a4aba5 is relevant for this PR, the others whre already merged before

@abahmed abahmed self-requested a review February 2, 2022 20:30
@abahmed abahmed merged commit 8b789e6 into abahmed:main Feb 3, 2022
@abahmed
Copy link
Copy Markdown
Owner

abahmed commented Feb 3, 2022

@simonfrey This happens due to squash & merge. check this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants