Skip to content

Allow to ignore if a container has to forcefully shutdown due to graceful shutdown not working#58

Merged
abahmed merged 5 commits intoabahmed:mainfrom
simonfrey:main
Jan 26, 2022
Merged

Allow to ignore if a container has to forcefully shutdown due to graceful shutdown not working#58
abahmed merged 5 commits intoabahmed:mainfrom
simonfrey:main

Conversation

@simonfrey
Copy link
Copy Markdown
Collaborator

@simonfrey simonfrey commented Jan 26, 2022

Fixes #44 , Fixes #50

Changes proposed in this pull request:

  • Adds a ignoreFailedGracefulShutdown config parameter which skips errors for containers which are killed during shutdown
  • Ignores valid exit codes as error source (exit codes ignore 0, 143)

@simonfrey simonfrey requested a review from abahmed as a code owner January 26, 2022 10:49
Copy link
Copy Markdown
Owner

@abahmed abahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)

@abahmed abahmed merged commit 0694ec2 into abahmed:main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"kwatch detected a crash in pod" when pod is deleted normally Don't send deployment rollout notifications

2 participants