Skip to content

fix: use result of replace method in sanitize.js#1471

Open
vlade1k wants to merge 1 commit intooverleaf:mainfrom
vlade1k:fix/backtick-replace-fix
Open

fix: use result of replace method in sanitize.js#1471
vlade1k wants to merge 1 commit intooverleaf:mainfrom
vlade1k:fix/backtick-replace-fix

Conversation

@vlade1k
Copy link
Copy Markdown

@vlade1k vlade1k commented Mar 25, 2026

Hello,
As a result of analyzing your project with the PVS-Studio static analyzer, we found the following error in your code. In the second method line, input may be replaced in an incorrect way because the right single quotation mark is not replaced. In this PR, we fix that.

Contributor Agreement

@lzear
Copy link
Copy Markdown
Contributor

lzear commented Mar 26, 2026

Thanks for your contribution!

We can't see your Github handle having signed the Contributor License Agreement. Let us know if you've signed with a different name. And could you add this to the PR description?

## Contributor Agreement

- [ ] I confirm I have signed the [Contributor License Agreement](https://github.com/overleaf/overleaf/blob/main/CONTRIBUTING.md#contributor-license-agreement)

@vlade1k
Copy link
Copy Markdown
Author

vlade1k commented Mar 26, 2026

@lzear
Thanks for the review!
I've just signed the Contributor License Agreement and added the confirmation checkbox to the PR description.
Let me know if anything else is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants