Fix broken repository URL in package.json#83
Open
ExplodingCabbage wants to merge 3 commits intominimistjs:mainfrom
Open
Fix broken repository URL in package.json#83ExplodingCabbage wants to merge 3 commits intominimistjs:mainfrom
ExplodingCabbage wants to merge 3 commits intominimistjs:mainfrom
Conversation
GitHub hasn't supported the git protocol [since 2022](https://github.blog/security/application-security/improving-git-protocol-security-github/#no-more-unauthenticated-git), so this URL is broken. (This is a common error affecting many popular npm packages; I'm opening PRs on several projects to fix it. I encourage anyone reading this to check any packages they maintain and implement the same fix if appropriate!)
ljharb
reviewed
Aug 13, 2025
package.json
Outdated
| "repository": { | ||
| "type": "git", | ||
| "url": "git://github.com/minimistjs/minimist.git" | ||
| "url": "https://github.com/minimistjs/minimist.git" |
Author
There was a problem hiding this comment.
Changed as requested - though as per inspect-js/has-symbols#22 (comment) I think https:// would be better.
Author
There was a problem hiding this comment.
Now changed to ssh:// per inspect-js/has-symbols#22 (comment)
shadowspawn
approved these changes
Aug 14, 2025
Member
shadowspawn
left a comment
There was a problem hiding this comment.
LGTM
Thanks for research too, via linked comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub hasn't supported the git protocol since 2022, so this URL is broken.
(This is a common error affecting many popular npm packages; I'm opening PRs on several projects to fix it. I encourage anyone reading this to check any packages they maintain and implement the same fix if appropriate!)