Fix #2: Print more information on failed requests#20
Merged
m1guelpf merged 2 commits intom1guelpf:mainfrom Jan 19, 2023
soerface:more-info-failed-response
Merged
Fix #2: Print more information on failed requests#20m1guelpf merged 2 commits intom1guelpf:mainfrom soerface:more-info-failed-response
m1guelpf merged 2 commits intom1guelpf:mainfrom
soerface:more-info-failed-response
Conversation
soerface
commented
Dec 27, 2022
| .unwrap(); | ||
|
|
||
| let status_code = response.status(); | ||
| if status_code.is_client_error() { |
Contributor
Author
There was a problem hiding this comment.
I wasn't able to get the response body after using error_for_status. It looks to me like the Error type does not expose the response body. Since error_for_status is not doing much more than turning the response into ok / error by using if status.is_client_error() || status.is_server_error() {, I just use those methods here directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discriminate between server and client errors. If it's a client error, parse the JSON to pretty print the failure reason. I assume that every client error response looks similar (contains
error.message).This is the response I got because a payment method was missing:
Fixes #2