Fix: Unknown date was displayed as 01-01-0001 - changed it to Unknown#5596
Open
xoores wants to merge 2 commits intoLidarr:developfrom
Open
Fix: Unknown date was displayed as 01-01-0001 - changed it to Unknown#5596xoores wants to merge 2 commits intoLidarr:developfrom
xoores wants to merge 2 commits intoLidarr:developfrom
Conversation
Author
|
Last commit reverts back the "No metadata" bandaid - now rows without metadata look like before: |
Contributor
|
Is this still needed with the metadata server +- recovered? |
Author
|
It never had anything to do with metadata server recovering. Some releases are just missing dates in the MB database 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Database Migration
NO
Description
Current metadata server returns unknown date as 01-01-0001, which is being displayed as a real date in UI.
This PR fixes this by checking this & displaying "Unknown" if appropriate (both artist detail & album detail).
I also added a "No metadata" info in case the album is missing metadata - this should help people identify that particular album is missing metadata & it should make it easier in support channels. This change is only in artist detail and should be only temporary until the metadata server is in full health - that's why I have not added a proper translation for this.
Sorting still works as I only changed the display value, not the actual value of 01-01-0001 that is being used internally.
Screenshot (if UI related)
Before
After