Fix problem with getting machine's current IP address.#129
Open
jon4than wants to merge 1 commit intovisad:masterfrom
Open
Fix problem with getting machine's current IP address.#129jon4than wants to merge 1 commit intovisad:masterfrom
jon4than wants to merge 1 commit intovisad:masterfrom
Conversation
On my Linux machine, the hostname will stay the same regardless of the network I'm on, while macOS will change the hostname (particularly evident when using wifi). This leads to attempting to resolve a potentially invalid hostname in an apparent effort to get the current IP (note: which is not the same thing as loopback/localhost). This commit simply grabs the local address from an extant Socket.
4b00692 to
2aeadff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my Linux machine, the hostname will stay the same regardless of the network I'm on, while macOS will change the hostname according to the whims of DHCP. This behavior is especially noticeable when hopping between wifi networks.
This leads to VisAD attempting to resolve a potentially invalid hostname in an apparent effort to get the current IP (note: not the same thing as loopback/localhost). The commit simply grabs the local address from the extant Socket.
I've tried this on both macOS and Linux and there were no problems, though the pull request should remain unmerged so that we can check Windows.