refactor: clean up TODO comments in core library#1131
Open
zubeyralmaho wants to merge 1 commit intouber:masterfrom
Open
refactor: clean up TODO comments in core library#1131zubeyralmaho wants to merge 1 commit intouber:masterfrom
zubeyralmaho wants to merge 1 commit intouber:masterfrom
Conversation
- directedEdge.c: Add proper error handling for cellToParent calls - h3api.h.in: Remove outdated release note from cellsToMultiPolygon docs - algos.c: Replace fuzzer-related TODOs with descriptive defensive comments - h3Index.c: Convert TODOs to issue reference and defensive notes - localij.c: Document known limitations for pentagon unfolding cases - vertexGraph.c: Update hash function performance note to NOTE - cellsToMultiPoly.c: Update edge iterator note to NOTE - polygon.c: Update polyfill refactoring note to NOTE These changes improve code documentation by: 1. Implementing proper error handling where TODOs indicated missing code 2. Converting speculative TODOs into accurate NOTE comments 3. Documenting known limitations instead of leaving unclear TODOs No functional changes to the library behavior.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes improve code documentation by:
No functional changes to the library behavior.