delete a baseUrl from a marker-end to resolve the disappearance of a path's arrow#413
Open
tkc-ohnuki wants to merge 1 commit intodagrejs:masterfrom
Open
delete a baseUrl from a marker-end to resolve the disappearance of a path's arrow#413tkc-ohnuki wants to merge 1 commit intodagrejs:masterfrom
tkc-ohnuki wants to merge 1 commit intodagrejs:masterfrom
Conversation
|
I ported the project to es6 and I accept contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the disappearance of a path's arrow in some use cases.
An arrowId is just enough to refer an arrow. And in some use cases, a baseUrl created by location.href causes a path's arrow to disappear.
For example, I use this library for drawing paths in a page whose url is changed by a user's action and set event listeners which change paths' color when users click them.
When the url is changed and one of the paths is clicked, it's arrow disappears.
Because it's mark-end reference url is invalid as a result of the difference between the url embedded when the path was rendered and the url changed by the user event.
I think the arrowId without the baseUrl is just enough to refer the arrow.
And to resolve the above matter, I propose deleting the baseUrl from the marker-end reference.