feat: loosen z.strictObject() inside intersection#5726
Open
vatsal9117 wants to merge 1 commit intocolinhacks:mainfrom
Open
feat: loosen z.strictObject() inside intersection#5726vatsal9117 wants to merge 1 commit intocolinhacks:mainfrom
vatsal9117 wants to merge 1 commit intocolinhacks:mainfrom
Conversation
|
Related Documentation Checked 0 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Author
|
feat: loosen z.strictObject() inside intersection #5726 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR resolves an issue where
z.strictObject()is functionally incompatible withz.intersection(). Previously, intersecting a strict object with another object would cause the strict object to throw anunrecognized_keyserror for any keys defined by the other half of the intersection.This update loosens the strictness exclusively within the context of intersections.
How it works:
In
src/v4/core/schemas.ts, thehandleIntersectionResultsfunction now tracks unrecognized keys from both theleftandrightschemas using a tracking Map.ZodErroris only thrown for keys that are completely unrecognized by both sides.Testing
Added test coverage in
src/v4/classic/tests/intersection.test.tsto verify:strict + stripbehavior (allows shared keys, strips unknown)strict + strictbehavior (allows shared keys, throws on completely unknown keys)