test: increase timeout for redos checker in datetime.test.ts#5744
Open
rishadaufa wants to merge 1 commit intocolinhacks:mainfrom
Open
test: increase timeout for redos checker in datetime.test.ts#5744rishadaufa wants to merge 1 commit intocolinhacks:mainfrom
rishadaufa wants to merge 1 commit intocolinhacks:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR increases the timeout for the
redos checkertest case insrc/v4/classic/tests/datetime.test.tsto 10s.Why?
As documented in #5743 (and previously discussed in #5365), this test is hitting the 5s limit on node 24.12.0 (LTS). This provides a buffer for the
rechecklibrary's execution on newer V8 engines.Verified on
Closes #5743