Skip to content
This repository was archived by the owner on Sep 21, 2022. It is now read-only.

npm failed to install due to old polyfill-service dep#673

Closed
SpaceK33z wants to merge 1 commit intogemini-testing:masterfrom
SpaceK33z:upgrade-polyfill-service
Closed

npm failed to install due to old polyfill-service dep#673
SpaceK33z wants to merge 1 commit intogemini-testing:masterfrom
SpaceK33z:upgrade-polyfill-service

Conversation

@SpaceK33z
Copy link
Copy Markdown

@SpaceK33z SpaceK33z commented Nov 15, 2016

By upgrading the polyfill-service, npm or yarn will no longer fail to install because of this message:

npm ERR! notsup Unsupported engine for hawk@0.10.2: wanted: {"node":"0.8.x"} (current: {"node":"6.8.1","npm":"3.10.8"})
npm ERR! notsup Not compatible with your version of node/npm: hawk@0.10.2
npm ERR! notsup Not compatible with your version of node/npm: hawk@0.10.2
npm ERR! notsup Required: {"node":"0.8.x"}
npm ERR! notsup Actual:   {"npm":"3.10.8","node":"6.8.1"}

In #635 it is mentioned that previously it wasn't possible to update since polyfill-service produced some console.log's that couldn't be hidden, but this was fixed in 3.13.0.

Fixes #635

@levonet levonet added the review label Nov 15, 2016
SevInf pushed a commit that referenced this pull request Nov 16, 2016
fix: remove polyfill-service dependency
9b9c007 
Fixes a lot of warnings regarding outdated dependecies and allows
to install gemini with yarn.

Close #673, close #635
@SevInf SevInf mentioned this pull request Nov 16, 2016
Merged
@SevInf SevInf self-assigned this Nov 16, 2016
SevInf pushed a commit that referenced this pull request Nov 16, 2016
fix: remove polyfill-service dependency
29462ca 
Fixes a lot of warnings regarding outdated dependecies and allows
to install gemini with yarn.

Close #673, close #635
@SevInf
Copy link
Copy Markdown
Contributor

SevInf commented Nov 16, 2016

Thanks for the contribution.
In the end, we've decided that pulling in 200MB website for picking 2 polyfills is not that good of idea, so we've removed the dependency altogether. For continuation see #674

@SevInf SevInf closed this Nov 16, 2016
@SevInf SevInf removed the review label Nov 16, 2016
@SpaceK33z
Copy link
Copy Markdown
Author

SpaceK33z commented Nov 16, 2016

@SevInf, oh that's even better, 200MB is really huge indeed.

@SpaceK33z SpaceK33z deleted the upgrade-polyfill-service branch November 16, 2016 14:19
SevInf pushed a commit that referenced this pull request Nov 17, 2016
fix: remove polyfill-service dependency
2b71a19 
Fixes a lot of warnings regarding outdated dependecies and allows
to install gemini with yarn.

Close #673, close #635
SevInf pushed a commit that referenced this pull request Nov 18, 2016
@SevInf
fix: remove polyfill-service dependency
364bcbf 
Fixes a lot of warnings regarding outdated dependecies and allows
to install gemini with yarn.

Close #673, close #635
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@SevInf SevInf

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

yarn install fails for gemini

3 participants

@SpaceK33z @SevInf @levonet