feat: remove deprecated CAPTURE event

j0tunn · j0tunn · commit d06a913db0d8 · 2017-11-02T22:49:57.000+03:00
diff --git a/lib/constants/events.js b/lib/constants/events.js
@@ -28,8 +28,6 @@ module.exports = {
     WARNING: 'warning',
     ERROR: 'err', // unable to call it `error` because `error` handling is a special case for EventEmitter
 
-    CAPTURE: 'capture', // Deprecated, will be removed in the next major version - 5.0.0
-
     TEST_RESULT: 'testResult',
     UPDATE_RESULT: 'updateResult',
 
diff --git a/lib/runner/browser-runner/index.js b/lib/runner/browser-runner/index.js
@@ -63,7 +63,6 @@ module.exports = class BrowserRunner extends Runner {
             Events.BEGIN_STATE,
             Events.END_STATE,
             Events.TEST_RESULT,
-            Events.CAPTURE,
             Events.UPDATE_RESULT,
             Events.WARNING,
             Events.ERROR,
diff --git a/lib/runner/index.js b/lib/runner/index.js
@@ -92,7 +92,6 @@ module.exports = class TestsRunner extends Runner {
 
         runner.on(Events.END_SUITE, (data) => this._suiteMonitor.suiteFinished(data.suite, data.browserId));
 
-        runner.on(Events.CAPTURE, (result) => this._handleResult(result, Events.CAPTURE));
         runner.on(Events.TEST_RESULT, (result) => this._handleResult(result, Events.TEST_RESULT));
         runner.on(Events.UPDATE_RESULT, (result) => this._handleResult(result, Events.UPDATE_RESULT));
 
diff --git a/lib/runner/suite-runner/insistent-suite-runner.js b/lib/runner/suite-runner/insistent-suite-runner.js
@@ -39,7 +39,6 @@ module.exports = class InsistentSuiteRunner extends SuiteRunner {
             Events.BEGIN_STATE,
             Events.SKIP_STATE,
             Events.END_STATE,
-            Events.CAPTURE,
             Events.UPDATE_RESULT,
             Events.WARNING
         ]);
diff --git a/lib/runner/suite-runner/regular-suite-runner.js b/lib/runner/suite-runner/regular-suite-runner.js
@@ -103,7 +103,6 @@ module.exports = class RegularSuiteRunner extends SuiteRunner {
             Events.BEGIN_STATE,
             Events.END_STATE,
             Events.TEST_RESULT,
-            Events.CAPTURE,
             Events.UPDATE_RESULT,
             Events.WARNING
         ]);
diff --git a/lib/state-processor/update-state-processor.js b/lib/state-processor/update-state-processor.js
@@ -15,7 +15,6 @@ module.exports = class UpdateStateProcessor extends StateProcessor {
     exec(state, browserSession, page, emit) {
         return super.exec(state, browserSession, page)
             .then((result) => {
-                emit(Events.CAPTURE, result);
                 emit(Events.UPDATE_RESULT, result);
             });
     }
diff --git a/test/unit/gemini.js b/test/unit/gemini.js
@@ -98,8 +98,6 @@ describe('gemini', () => {
         Events.WARNING,
         Events.ERROR,
 
-        Events.CAPTURE,
-
         Events.TEST_RESULT,
         Events.UPDATE_RESULT
     ].forEach((event) => {
diff --git a/test/unit/runner/index.js b/test/unit/runner/index.js
@@ -502,7 +502,6 @@ describe('runner', () => {
             });
 
             [
-                Events.CAPTURE,
                 Events.TEST_RESULT,
                 Events.UPDATE_RESULT
             ].forEach((event) => {
diff --git a/test/unit/runner/suite-runner/insistent-suite-runner.js b/test/unit/runner/suite-runner/insistent-suite-runner.js
@@ -65,7 +65,6 @@ describe('runner/suite-runner/insistent-suite-runner', () => {
         Events.SKIP_STATE,
         Events.END_STATE,
         Events.TEST_RESULT,
-        Events.CAPTURE,
         Events.UPDATE_RESULT,
         Events.WARNING
     ].forEach((stateEvent) => it(`should passthrough ${stateEvent} state`, () => {
@@ -454,8 +453,7 @@ describe('runner/suite-runner/insistent-suite-runner', () => {
                 Events.UPDATE_RESULT,
                 Events.TEST_RESULT,
                 Events.WARNING,
-                Events.ERROR,
-                Events.CAPTURE
+                Events.ERROR
             ].forEach((event) => {
                 it(`${event}`, () => {
                     const config = mkConfigStub_({retry: 0});

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@ module.exports = class UpdateStateProcessor extends StateProcessor {`
`15`	`15`	`exec(state, browserSession, page, emit) {`
`16`	`16`	`return super.exec(state, browserSession, page)`
`17`	`17`	`.then((result) => {`
`18`		`- emit(Events.CAPTURE, result);`
`19`	`18`	`emit(Events.UPDATE_RESULT, result);`
`20`	`19`	`});`
`21`	`20`	`}`
Original file line number	Diff line number	Diff line change
`@@ -502,7 +502,6 @@ describe('runner', () => {`
`502`	`502`	`});`
`503`	`503`
`504`	`504`	`[`
`505`		`- Events.CAPTURE,`
`506`	`505`	`Events.TEST_RESULT,`
`507`	`506`	`Events.UPDATE_RESULT`
`508`	`507`	`].forEach((event) => {`