fix: load plugins only once

j0tunn · j0tunn · commit a56e39b5eee5 · 2017-11-02T14:53:40.000+03:00
diff --git a/lib/gemini.js b/lib/gemini.js
@@ -103,8 +103,12 @@ module.exports = class Gemini extends PassthroughEmitter {
     }
 
     _exec(fn) {
-        const plugins = pluginsLoader.load(this, this.config.system.plugins, PREFIX);
-        return bluebirdQ(Promise.all(plugins).then(() => fn()));
+        return bluebirdQ(this._loadPlugins().then(() => fn()));
+    }
+
+    _loadPlugins() {
+        this._loadPlugins = () => Promise.resolve(); // load plugins only once
+        return Promise.all(pluginsLoader.load(this, this.config.system.plugins, PREFIX));
     }
 
     _readTests(paths, options) {
diff --git a/test/unit/gemini.js b/test/unit/gemini.js
@@ -183,6 +183,14 @@ describe('gemini', () => {
             return assert.isRejected(result, err)
                 .then(() => assert.notCalled(Runner.prototype.run));
         });
+
+        it('should load plugins only once', () => {
+            const gemini = initGemini();
+
+            return gemini.readTests()
+                .then((collection) => gemini.test(collection))
+                .then(() => assert.calledOnce(pluginsLoader.load));
+        });
     });
 
     describe('readTests', () => {

Original file line number	Diff line number	Diff line change
`@@ -103,8 +103,12 @@ module.exports = class Gemini extends PassthroughEmitter {`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`_exec(fn) {`
`106`		`- const plugins = pluginsLoader.load(this, this.config.system.plugins, PREFIX);`
`107`		`- return bluebirdQ(Promise.all(plugins).then(() => fn()));`
	`106`	`+ return bluebirdQ(this._loadPlugins().then(() => fn()));`
	`107`	`+ }`
	`108`	`+`
	`109`	`+ _loadPlugins() {`
	`110`	`+ this._loadPlugins = () => Promise.resolve(); // load plugins only once`
	`111`	`+ return Promise.all(pluginsLoader.load(this, this.config.system.plugins, PREFIX));`
`108`	`112`	`}`
`109`	`113`
`110`	`114`	`_readTests(paths, options) {`