feat(new-browser): change default value for resetZoom

DudaGod · DudaGod · commit 50069272f8e4 · 2018-01-10T19:34:09.000+03:00
diff --git a/lib/browser/new-browser.js b/lib/browser/new-browser.js
@@ -185,14 +185,14 @@ module.exports = class NewBrowser extends Browser {
     }
 
     openRelative(relativeURL) {
-        return this.open(this.config.getAbsoluteUrl(relativeURL));
+        return this.open(this.config.getAbsoluteUrl(relativeURL), {resetZoom: true});
     }
 
     // Zoom reset should be skipped before calibration cause we're unable to build client scripts before
     // calibration done. Reset will be executed as 1 of calibration steps.
     open(url, params) {
         params = _.defaults(params || {}, {
-            resetZoom: true
+            resetZoom: false
         });
 
         return this._wd.get(url)
diff --git a/test/unit/browser/new-browser.js b/test/unit/browser/new-browser.js
@@ -304,14 +304,14 @@ describe('browser/new-browser', () => {
                     .then(() => assert.calledWith(wd.get, 'http://www.example.com'));
             });
 
-            it('should reset page zoom by default', () => {
+            it('should not reset page zoom by default', () => {
                 return open(browser, {url: 'http://www.example.com'})
-                    .then(() => assert.calledWith(ClientBridge.prototype.call, 'resetZoom'));
+                    .then(() => assert.neverCalledWith(ClientBridge.prototype.call, 'resetZoom'));
             });
 
-            it('should not reset page zoom if `resetZoom` param passed as false', () => {
-                return open(browser, {url: 'http://www.example.com', resetZoom: false})
-                    .then(() => assert.neverCalledWith(ClientBridge.prototype.call, 'resetZoom'));
+            it('should reset page zoom if `resetZoom` param passed as true', () => {
+                return open(browser, {url: 'http://www.example.com', resetZoom: true})
+                    .then(() => assert.calledWith(ClientBridge.prototype.call, 'resetZoom'));
             });
         });
 

Original file line number	Diff line number	Diff line change
`@@ -185,14 +185,14 @@ module.exports = class NewBrowser extends Browser {`
`185`	`185`	`}`
`186`	`186`
`187`	`187`	`openRelative(relativeURL) {`
`188`		`- return this.open(this.config.getAbsoluteUrl(relativeURL));`
	`188`	`+ return this.open(this.config.getAbsoluteUrl(relativeURL), {resetZoom: true});`
`189`	`189`	`}`
`190`	`190`
`191`	`191`	`// Zoom reset should be skipped before calibration cause we're unable to build client scripts before`
`192`	`192`	`// calibration done. Reset will be executed as 1 of calibration steps.`
`193`	`193`	`open(url, params) {`
`194`	`194`	`params = _.defaults(params \|\| {}, {`
`195`		`- resetZoom: true`
	`195`	`+ resetZoom: false`
`196`	`196`	`});`
`197`	`197`
`198`	`198`	`return this._wd.get(url)`