-
Notifications
You must be signed in to change notification settings - Fork 25
Live-reload displays blank page on Windows 10 #26
Description
Attempted to run dataflow on a Windows 10 computer. Initial load of a notebook works, however changing the notebook using notepad++ causes the page to become and remain blank.
The issue is that the file is empty for the brief moment when dataflow receives a file change notification. I'm not entirely sure why Windows behaves this way but I've seen similar issues in Python modules that watch for file changes. Perhaps opening the file for writing changes the length to 0 and triggers file change notification, then it finally updates after writing completes. It's also odd that dataflow doesn't receive notification when the write completes.
On my computer Notepad++ triggers this issue every time. Atom only trigger this issue when the file becomes large enough. Notepad continued to work, but maybe my test file wasn't large enough to trigger the issue.
I did the simplest possible fix and did added a setTimeout for 100mS in run.js before attempting to read the file. In general some sort of debounce seems necessary, whether that's a fixed delay or more intelligent checks to determine when the file is no longer changing.